search

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results
https://qiicr.gitbook.io/dcmqi-guide/
BSD 3-Clause "New" or "Revised" License
232 stars 62 forks source link

dcmqi target install step #423

Closed lorteddie closed 3 years ago

lorteddie commented 3 years ago

kind of trying things out here, it works for my setup but i don't ever build superbuild

fedorov commented 3 years ago

@rfloca @kislinsk do you mind checking if this will work with MITK superbuild?

rfloca commented 3 years ago

Yes sure.

fedorov commented 3 years ago

@lorteddie can you let me know if/when this PR is ready for testing? Also, would it make sense to squash some commits, or you think each one deserves to be preserved?

lorteddie commented 3 years ago

yes I redid the commits, was definitely too much trial and error commits I tested that dcmqi target etc is not installed if build via superbuild because cmake will complain that include directories are pointing into the build directory because of ITK and DCMTK. And I tested that it is actually installed if build separately which makes the cmake integration into other projects a lot easier. If it works for MITK I think we are good here.

fedorov commented 3 years ago

Great, thank you! I am going to merge, and see how Slicer dashboard reacts to this. We can revert back if there are issues with Slicer or MITK identified.

rfloca commented 3 years ago

Hi, checked it with our current develop branch. It builds and the quick smoke test with our installer also seems to work. If we should still find problems we let you know.