search

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results
https://qiicr.gitbook.io/dcmqi-guide/
BSD 3-Clause "New" or "Revised" License
232 stars 62 forks source link

Dcmqi install step improvements #432

Closed lorteddie closed 3 years ago

fedorov commented 3 years ago

@akalali FYI - in case you want to check this in the context of #429

fedorov commented 3 years ago

@lorteddie are you still working on this, or it is ready to merge?

lorteddie commented 3 years ago

ready from my side, unfortunately i didn't test the last cmake change after removing the build directory, this change fixes paths in the cmake files pointing into the build directory i also removed the zlib include since i don't understand why it is there (and it fails with dcmtk built with zlib). and since the dcmtk cmake config file still uses library and include paths instead of targets, their dependencies like zlib aren't covered by DCMTK_INCLUDE_DIRS

fedorov commented 3 years ago

I will merge, but will see how this plays with the Slicer superbuild.