Fix Windows Release publishing.

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results

https://qiicr.gitbook.io/dcmqi-guide/

BSD 3-Clause "New" or "Revised" License

234 stars 62 forks source link

Fix Windows Release publishing. #476

Closed michaelonken closed 1 year ago

michaelonken commented 1 year ago

Use powershell multi-line command separators (backticks) for long command line call.

fedorov commented 1 year ago

Oh wow! I did have those backticks, but I removed them, since I thought they are an artifact of Appveyor syntax. Thank you for catching this! Not sure why it is failing now.... We also should look (at some point) how to disable package generation and upload when the workflow is triggered on PR.

michaelonken commented 1 year ago

I suspect that windows build above fails since the secret.GA_TOKEN is probably not accessible from my pull request (see also same error on Linux build for this PR).

I tried on my own repo with my own token and it seems to be fine in general.

fedorov commented 1 year ago

I am merging this one, since overall PRs do not need to be generating packages, so we can ignore those errors for now I guess.