search

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results
https://qiicr.gitbook.io/dcmqi-guide/
BSD 3-Clause "New" or "Revised" License
228 stars 62 forks source link

Add fetch tags to exisitng workflows #483

Closed vkt1414 closed 8 months ago

vkt1414 commented 8 months ago

To address #482, I found that the reason for scikit unable to make releases with tagged commits (w/ versioned tags). The git checkout action does not fetch tags unless we explicitly mention it. Some discussion can be seen here..https://github.com/actions/checkout/issues/206 I came to know about this issue when I simply wanted to see the tags while running the GitHub actions workflow with 'git describe' and the logs said no tags found. I then searched if this is a common issue and found the above discussion. image

vkt1414 commented 8 months ago

update: I modified some minor changes to expected release file names and everything should now work as expected.

fedorov commented 8 months ago

Very nice! How did you figure this out?! Thank you, this is very helpful! I will make a release tag a bit later to check if this indeed works.

I am going to squash the commits to keep history more clean. Next time you can do git rebase -i (see here) and force-push.

vkt1414 commented 8 months ago

Thanks, @fedorov for the tip. I absolutely need to learn more git tricks, particularly git rebase I guess as on more than one occasion I wanted to simplify the commit history.

The discussion here about tags helped solve (hopefully) this issue..https://github.com/actions/checkout/issues/206