New distribution: ParticleDistribution - Githubissues

QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.

BSD 3-Clause "New" or "Revised" License

92 stars 31 forks source link

New distribution: ParticleDistribution #106

Closed ihincks closed 7 years ago

ihincks commented 7 years ago

This PR simply adds the new distribution ParticleDistribution and corresponding tests. All methods and properties of SMCUpdater which were (in my opinion) relevant to a bare particle distribution were copied over (but left intact). This is the first step of #105. The next step, in my view, is to implement the hierarchy ParticleDistribution>AbstractUpdater>SMCUpdater.

It would be worthwhile for someone to compare the properties and methods of ParticleDistribution and SMCUpdater to check if my choices are appropriate and comprehensive.

[Sorry for all the whitespace changes my text editor did automatically]

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 1bef90ed4eee2c2ccf772ab396df39294bd8464c on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 66ace2db847fcd9de47ec9a6cd88a9f694071e1e on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 66ace2db847fcd9de47ec9a6cd88a9f694071e1e on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 66ace2db847fcd9de47ec9a6cd88a9f694071e1e on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 66ace2db847fcd9de47ec9a6cd88a9f694071e1e on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.

cgranade commented 7 years ago

Thanks, this looks like a very good start on #105! I'll look over and see if I have any concrete suggestions, but after a cursory look, I think it's great.

Before merging, I'd like to fix the Travis build error, though. It looks like it's unrelated to this PR, but is happening due to changes in QuTiP upstream; now that 4.0 is out, we should be able to make the doctest build more stable, so I'll go on and take care of that in a separate PR soon. Thanks!

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 5ff3f5a43773bc5ae4c7788a41fae401b2e7b31b on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 67.713% when pulling 5ff3f5a43773bc5ae4c7788a41fae401b2e7b31b on ihincks:feature-particle-distribution into a93f9d2a971258f6f7a0e9e645b28f7601711067 on QInfer:master.