search

QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.
BSD 3-Clause "New" or "Revised" License
92 stars 31 forks source link

Domains Errors #111

Closed taalexander closed 7 years ago

taalexander commented 7 years ago

Currently domains will fail as min/max values are by default set to None when bounds have not been set. This will cause various methods to fail either from attempting to cast a None type to int or comparing against a None type. This may be simply fixed by setting the bounds to +-np.inf

ihincks commented 7 years ago

Good catch. Out of curiosity, what's an example of a method that fails?

taalexander commented 7 years ago

When running test_concrete_models.py over BasicGaussianModel the in_domain check will fail on simulated data as it will attempt to compare the generated data against a None min/max value as the domain is set to RealDomain(). Another case is for BasicPoissonModel() as the the max is None and __init__ will try and cast int(max) which is equivalent to int(None) which fails.

ihincks commented 7 years ago

Fixed with #112