Canonicalize after update_timestep?

QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.

BSD 3-Clause "New" or "Revised" License

92 stars 31 forks source link

Canonicalize after update_timestep? #118

Closed ihincks closed 7 years ago

ihincks commented 7 years ago

We may want to consider the default behaviour (assuming _canonicalize is True) of SMCUpdater.update calling canonicalize on the modelparams after a non-trivial application of update_timestep.

ihincks commented 7 years ago

Hmm, I'm flip-flopping between the above, and just making Model.update_timestep do it itself. Given my indecision, I am now favouring the latter since it involves no PRs.

ihincks commented 7 years ago

Closing for now as it is not a problem.