search

QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.
BSD 3-Clause "New" or "Revised" License
92 stars 31 forks source link

Remove docopt #122

Closed cgranade closed 7 years ago

cgranade commented 7 years ago

This PR completely removes docopt from _lib since we're no longer using it at all.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.4%) to 71.76% when pulling d0d6451bf8cd1fcf33a8dfca8e81a85800e9c1fb on remove-docopt into ad5be44deeb9f1df5b4c5488d4046c9e9b5993c3 on master.

cgranade commented 7 years ago

Since this passes all tests, I think that's a pretty good indication that there's not any dependencies on docopt that I missed. Should be ready to merge in once #121 is merged.

ihincks commented 7 years ago

Would you mind just triggering a travis rebuild to be safe? I usually do `git commit --allow-empty -m ..", but apparently the travis website also has a refresh button for those with admin access.

cgranade commented 7 years ago

Sounds good, will do. I apologize about not exposing the "Restart build" option, there doesn't seem to be a way to delegate or share access to the Travis build controls. One workaround I've found that's a bit of a pain is to use your own fork of the repo so that you have direct control over Travis on that fork. Certainly not a great option, though, given that you really should just have access to build controls directly.

cgranade commented 7 years ago

Looks like the tests still pass under the fresh build, so I think that's a pretty good indication that we haven't missed anything.