Fix test_model - Githubissues

QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.

BSD 3-Clause "New" or "Revised" License

92 stars 31 forks source link

Fix test_model #132

Closed ihincks closed 7 years ago

ihincks commented 7 years ago

The function test_model has apparently been broken for a while; it depended on some old names, etc. This fixes it and makes it visible as qinfer.tests.test_model, thereby addressing #131 too.

ihincks commented 7 years ago

Hmm, I don't know what the Python 3.3 error means.

cgranade commented 7 years ago

I'm not sure either, but at least some projects report that this is a symptom of an out-of-date pip. Perhaps we should do a pip update pip at the start of _travis.yml to guard against hitting this bug?

ihincks commented 7 years ago

Good thinking. pip was up to date in all versions except 3.3 for some reason.

ihincks commented 7 years ago

I'm going to make another commit adding test_model to the docs; I have personally found it useful for my custom models, as it can help debug indexing errors that are tedious to debug otherwise.

coveralls commented 7 years ago

Coverage increased (+1.7%) to 74.171% when pulling 62a265d9eb39f3d11187c6a3fc92b257c609fc28 on ihincks:fix-test_model into 4d0aee343ce2a14133a0ad1805b12c28719b6018 on QInfer:master.

coveralls commented 7 years ago

Coverage increased (+1.7%) to 74.171% when pulling 6c9d7e03f073d7b4487ba7a572a6c4e923c248f5 on ihincks:fix-test_model into 4d0aee343ce2a14133a0ad1805b12c28719b6018 on QInfer:master.

ihincks commented 7 years ago

H'okay, this PR is ready for comments. Urgency: low.

cgranade commented 7 years ago

Looks great, thanks for fixing this! ♥