QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.
BSD 3-Clause "New" or "Revised" License
92 stars 31 forks source link

Move ReadTheDocs configuration to use YAML config #147

Closed cgranade closed 6 years ago

cgranade commented 6 years ago

This PR fixes build issues with the ReadTheDocs pipeline by moving over to a YAML-based configuration that gives us a bit more control. In particular, we can then move QuTiP to install after Cython has been installed, working around a bug in QuTiP's setup.py.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 74.691% when pulling 35af41eecf3359065d1df9d7c72b33c32bd032cb on cgranade/fix-rtd-1 into 3c9cc7e0194a92c6563392979d4d9cb693fb9eef on master.

ihincks commented 6 years ago

Out of interest, could you briefly explain why qutip needs this special attention? (I may be adding it as a requirement to another project sometime soon)

cgranade commented 6 years ago

The basic problem with including QuTiP is that its setup.py script needs Cython to already be installed. When pip tries to collect a list of dependencies it fails due to Cython not being present. The conda-forge recipe for QuTiP avoids this problem, as does installing with pip after Cython has been successfully installed.

cgranade commented 6 years ago

It looks like adding conda-forge as required for using the QuTiP conda package broke the RTD build, so I'll go on and revert b25fe97 and merge this in with the pip: ['qutip'] hack in place.