search

QInfer / python-qinfer

Library for Bayesian inference via sequential Monte Carlo for quantum parameter estimation.
BSD 3-Clause "New" or "Revised" License
92 stars 31 forks source link

Possible bug in Resampler #148

Open nzqo opened 6 years ago

nzqo commented 6 years ago

Considering the mus are not ordered, should one not use the mask to specify the remaining kernel locations around which there is still sampling to be done? In the simplest case, assume that only the last particle location in mu yields an invalid particle location when drawing, then in the current situation the algorithm would resample from a gaussian centered around the first location mu[0], not the last.

Edit: tried to add a fix

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 75.631% when pulling 7fc8260828d6f214dab8461c07c83dc9cdee664b on LiftingBanana:master into 8170c84a0be1723f8c6b09e0d3c7a40a886f1fe3 on QInfer:master.

cgranade commented 5 years ago

My apologies for the delay, I've been on travel for a bit. Thanks for pointing out this issue, in any case. I'd like to investigate a bit further before I say something wrong, but I think there may indeed be a bit of a problem here.