Ability to change font size

[joonro]

I use quicklook to look at text files a lot, and currently I found the font to be too small.

It would be great if quicklook supports the ability to set the preferred font size.

Thank you!

[thepragg]

I use quicklook to look at text files a lot, and currently I found the font to be too small.

Huh.., I myself find it too big!! Guess this really goes to prove the "To Each His Own" adage even true-er. Anyway, I have a suggestion for a quick fix on this issue, before implementing your own robust solution;

1st_ I should/must preface my suggestion by stating that I know nothing of coding apps/programs, although I am however an intermediate webdesign learner [js, css, html*], so I can at-least read and to an extent understand the workings of '.cs' files.

2nd_on to the suggestion., from reading the TextViewerPanel.cs file, on L56: FontFamily = new FontFamily(TranslationHelper.Get("Editor_FontFamily"));,

the TextViewer Plugin gets its default font from the Translations.config file__e.g for english users, L5: <Editor_FontFamily>Consolas</Editor_FontFamily>

TL_DR:

@xupefei , 'Knowing' this, I was thinking that maybe inside Translations.config, we could have another line above/below/within the '</Editor_FontFamily>' tag to define/set font-size, which can then be similarly referenced within TextViewerPanel.cs. i.e;

Translations.config: <Editor_FontSize>16</Editor_FontSize>

TextViewerPanel.cs: FontSize = new FontSize(TranslationHelper.Get("Editor_FontSize"));

OR Maybe we can have [another separate OR one unifying(+the existing Translations.config)] .config file, serving to define default properties e.g bgcolor, fgcolor, lineSpacing/Height, fontFamily, font-size, etc.., of which the 1st 3 can be overridden by file_specific '.xshd' Syntax Files.

I hope my understanding &/ judgement was at-least 80% sound and my suggestion plausible enough to warrant a fix, Cheers Mate, and Happy Coding!!

[xupefei]

Put it into the config is certainly an option, but modifying it will be impossible for Windows Store users. In fact, I am thinking about to have CTRL+Scroll for adjusting the font size. But I thought it would be a little overkill…

Cheers, Paddy

On 20 Aug 2018, at 01:48, Marlon Grivois notifications@github.com wrote:

I use quicklook to look at text files a lot, and currently I found the font to be too small.

Huh.., I myself find it too big!! Guess this really goes to prove the "To Each His Own" adage even true-er. Anyway, I have a suggestion for a quick fix on this issue, before implementing your own robust solution;

1st_ I should/must preface my suggestion by stating that I know nothing of coding apps/programs, although I am however an intermediate webdesign learner [js, css, html*], so I can at-least read and to an extent understand the workings of '.cs' files.

2nd_on to the suggestion., from reading the TextViewerPanel.cs https://github.com/QL-Win/QuickLook/blob/master/QuickLook.Plugin/QuickLook.Plugin.TextViewer/TextViewerPanel.cs file, on L56 https://github.com/QL-Win/QuickLook/blob/112f5409cf721df52314a367477068bf8af3958d/QuickLook.Plugin/QuickLook.Plugin.TextViewer/TextViewerPanel.cs#L56: FontFamily = new FontFamily(TranslationHelper.Get("Editor_FontFamily"));,

the TextViewer Plugin gets its default font from the Translations.config https://github.com/QL-Win/QuickLook/blob/master/QuickLook.Plugin/QuickLook.Plugin.TextViewer/Translations.config file__e.g for english users, L5 https://github.com/QL-Win/QuickLook/blob/112f5409cf721df52314a367477068bf8af3958d/QuickLook.Plugin/QuickLook.Plugin.TextViewer/Translations.config#L5:

Consolas

TL_DR:

@xupefei https://github.com/xupefei , 'Knowing' this, I was thinking that maybe inside Translations.config, we could have another line above/below/within the '' tag to define/set font-size, which can then be similarly referenced within TextViewerPanel.cs. i.e;

Translations.config:

16

TextViewerPanel.cs: FontSize = new FontSize(TranslationHelper.Get("Editor_FontSize"));

OR Maybe we can have [another separate OR one unifying(+the existing Translations.config)] .config file, serving to define default properties e.g bgcolor, fgcolor, lineSpacing/Height, fontFamily, font-size, etc.., of which the 1st 3 can be overridden by file_specific '.xshd' Syntax Files.

I hope my understanding &/ judgement was at-least 80% sound and my suggestion plausible enough to warrant a fix, Cheers Mate, and Happy Coding!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/QL-Win/QuickLook/issues/271#issuecomment-414161573, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnBJ0A6eBdCmBYZejNSClaJE8PzDygjks5uSetKgaJpZM4U4OkU.

[snowman]

This is a must-have feature, please consider supporting it

The default font size is too small to read

[edshamis]

It would be great to have this ability Thanks!