useless warning triggered

[mvbnano]

What is affected by this bug?

This error keeps triggering:

warning ConfocalScannerInterfaceDummy>set_up_scanner

When does this occur?

each time 'optimise position' is clicked

Where on the platform does it happen?

Not sure.

How do we replicate the issue?

optimise on a ND

Expected behavior (i.e. solution)

find whatever is generating the error and kill it

Other Comments

workflow unaffected

[mvbnano]

Located on line 149 of confocal_scanner_pi_piezo_interfuse.py

    def set_up_scanner(self, counter_channel = None, photon_source = None, clock_channel = None, scanner_ao_channels = None):
        """ Configures the actual scanner with a given clock.

        TODO this is not technically required, because the spectrometer scanner does not need clock synchronisation.

        @param string counter_channel: if defined, this is the physical channel of the counter
        @param string photon_source: if defined, this is the physical channel where the photons are to count from
        @param string clock_channel: if defined, this specifies the clock for the counter
        @param string scanner_ao_channels: if defined, this specifies the analoque output channels

        @return int: error code (0:OK, -1:error)
        """
        self.log.warning('ConfocalScannerInterfaceDummy>set_up_scanner')
        return 0

@latchr Do you know what this function is for? It's getting called often, but does nothing. I think we do not need to call it, and can at least silence the warning.

[latchr]

The log.warning message is not needed. It is lingering there from an initial copy from the dummy hardware file. Delete it but keep the return 0

On Thu, Nov 30, 2017, 12:34 PM mvbnano notifications@github.com wrote:

Located on line 149 of confocal_scanner_pi_piezo_interfuse.py

def set_up_scanner(self, counter_channel = None, photon_source = None, clock_channel = None, scanner_ao_channels = None):
    """ Configures the actual scanner with a given clock.        TODO this is not technically required, because the spectrometer scanner does not need clock synchronisation.        @param string counter_channel: if defined, this is the physical channel of the counter        @param string photon_source: if defined, this is the physical channel where the photons are to count from        @param string clock_channel: if defined, this specifies the clock for the counter        @param string scanner_ao_channels: if defined, this specifies the analoque output channels        @return int: error code (0:OK, -1:error)        """
    self.log.warning('ConfocalScannerInterfaceDummy>set_up_scanner')
    return 0

@latchr https://github.com/latchr Do you know what this function is for? It's getting called often, but does nothing. I think we do not need to call it, and can at least silence the warning.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/QMAPP-mq/qudi/issues/11#issuecomment-348054370, or mute the thread https://github.com/notifications/unsubscribe-auth/ARUzY7ohjYswEsfsS8W3u-260R-p0gM7ks5s7gYogaJpZM4QoMJ2 .

[mvbnano]

Thanks mate. warning removed, branch ready to merge.