search

QMAPP-mq / qudi

A modular laboratory experiment management suite.
GNU General Public License v3.0
4 stars 0 forks source link

_do_move_abs not connected? #16

Closed mvbnano closed 6 years ago

mvbnano commented 6 years ago

On branch _pi_usb_digital_control (and likely pi_pci_digital_control) the function _do_move_abs does not appear to be called. It appears to have been written (by QMAPP devs) do be a better way of setting the scanner position, whereby you can not move out-of-bounds.

Prior to merging upstream this should be looked in to.

mvbnano commented 6 years ago

This now applies on branch dev_ntmdt_stage also.

mvbnano commented 6 years ago

This now applies on branch dev_newfocus_screws also.

mvbnano commented 6 years ago

This is now smartly implemented in ntmdt_piezo_stage.py on branch dev_ntmdt_stage. This should be used as a standard for the implementation on our other development branches.

mvbnano commented 6 years ago

Can be resolved on branch dev_newfocus_screws once issue #28 has been resolved.

mvbnano commented 6 years ago

Implemented smarter absolute movement on all dev branches excluding dev_newfocus_screws.

@MyrddynEmrys Once your constraints are loaded as per issue #28 we will implement constraint checking on that branch too.