Fix GCC14-flagged uninitialized use warnings - Githubissues

QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support

http://www.qmcpack.org

Other

295 stars 138 forks source link

Fix GCC14-flagged uninitialized use warnings #4981

Closed prckent closed 4 months ago

prckent commented 4 months ago

Proposed changes

With our default compilation options GCC14 usefully flags a couple of new routes to uninitialized variable use. Fixed.

There is still a large but not-new warning coming from ppconvert IO handling that I did not fix.

What type(s) of changes does this code introduce?

Bugfix

Does this introduce a breaking change?

No

What systems has this change been tested on?

nitrogen2, nightly config with trial installation of gcc 14.1

Checklist

Yes This PR is up to date with current the current state of 'develop'
Yes. Code added or changed in the PR has been clang-formatted
No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
No. Documentation has been added (if appropriate)

ye-luo commented 4 months ago

Test this please