QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support
http://www.qmcpack.org
Other
295 stars 138 forks source link

extend h5 data proxy for std::vector<bool> needed for EDE #4982

Closed PDoakORNL closed 4 months ago

PDoakORNL commented 4 months ago

Proposed changes

std::vector is an exception case so it needs it own h5dataproxy. There isn't a matching h5 data type so I convert it to/from char type. This is used by the energy density estimator to avoid adhoc kludging there.

What type(s) of changes does this code introduce?

Delete the items that do not apply

Does this introduce a breaking change?

What systems has this change been tested on?

osx laptop

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

ye-luo commented 4 months ago

Test this please