Closed ye-luo closed 2 weeks ago
@jtkrogel could you review?
writebuffer requires the same set of collectors as startRun. Since the code has be changed to capture the set of references at the startRun, writebuffer doesn't need to take the set again as argument any longer. startRun stopRun and writeBuffer are the only three public APIs. With PR, only startRun takes a set of references to collectors. So less error-prone. Regarding private functions, I tried to leave the set of references to collectors as an argument if it helps making the function const. Such functions are more like free functions preferably not pulling member variables directly for exmaple checkCollectors. Regarding the other private member functions openFile openHDFFile, I feel there is some design but the implementation is incomplete and thus leave them as they are.
Test this please
Proposed changes
Made the following changes.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist