QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support
http://www.qmcpack.org
Other
283 stars 135 forks source link

A strange saveWalker call at MCpopulation #5069

Closed ye-luo closed 3 days ago

ye-luo commented 1 week ago

https://github.com/QMCPACK/qmcpack/pull/5063#discussion_r1655626388 Needs visiting. Right now MCpopulation::saveWalkerConfigurations seems showing two source of truth. Walker configuration can be source from walker_elec_particle_sets_ and walkers_. Better clearly define the scope of both objects when data is up-to-date.