QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support
http://www.qmcpack.org
Other
302 stars 139 forks source link

Introduce MultiSplineBase and MultiSplineOffload classes #5197

Closed ye-luo closed 1 month ago

ye-luo commented 1 month ago

Review after #5195

Proposed changes

Introduce MultiSplineBase as the base class for MultiSpline and MultiSplineOffload. When implementing R2R offload, I'm trying to prevent creating an offload class by copying the whole R2R class. As a preparation step, I need to make MultiSpline abstracted.

What type(s) of changes does this code introduce?

Does this introduce a breaking change?

What systems has this change been tested on?

epyc-server

Checklist

ye-luo commented 1 month ago

Test this please

ye-luo commented 1 month ago

Test this please

ye-luo commented 1 month ago

Test this please