QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support
http://www.qmcpack.org
Other
302 stars 139 forks source link

Nexus: Bugfix for SOC J3 terms #5200

Closed aannabe closed 1 month ago

aannabe commented 1 month ago

Proposed changes

In #5184, I introduced the handling of J3 terms in Nexus for SOC calculations. At the time I tested it in CrI3, which has two species. For single-element systems such as Ir, the data structure of J3 terms changes (reported by @rcclay). In this edge case, nothing needs to be done when incorporating the previous Jastrow, since there will be only a single 'uu' term in J3.

What type(s) of changes does this code introduce?

Does this introduce a breaking change?

What systems has this change been tested on?

NERSC. Nexus tests are passing.

Checklist

aannabe commented 1 month ago

Added an explicit check for the above-described case.

ye-luo commented 1 month ago

Test this please