QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support
http://www.qmcpack.org
Other
300 stars 139 forks source link

[WIP] Batched converter #5231

Open anbenali opened 1 week ago

anbenali commented 1 week ago

Please review the developer documentation on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here This PR introduces 2 changes:

  1. Support for gpu4pyscf in the PyscfToQmcpack.py code to handle Cupy changes in mf.mocoeff.
  2. convert4qmc generates by default batch code instead of legacy. to generate old legacy input, --legacy is needed.

What type(s) of changes does this code introduce?

Delete the items that do not apply

Does this introduce a breaking change?

What systems has this change been tested on?

-Endymion (personal Server - AMD ROME 7503 - NVIDIA Geforce RTX 4070 Titanium Super)

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

anbenali commented 1 week ago

tests need to be updated to match. unfortunately, if b3lyp is called like in most examples, DFT gives different values as the definition of B3LYP has changed in the past years and new QMC runs are needed.

Help to create tests is required @prckent @Hyeondeok-Shin

prckent commented 3 days ago

Suggesting a fast route to get this merged:

  1. I think you only need to update the gold files to get the converter tests passing -- QMC runs are not done. We can run spot checks once the tests are passing.
  2. Some testing of --legacy is needed. Probably easiest to duplicate the tests and add a set of gold files. Could do for just one test if the code paths are close enough.