Make changes to rely on ADL get instead of std::get in AFQMC

QMCPACK / qmcpack

Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids with full performance portable GPU support

http://www.qmcpack.org

Other

302 stars 139 forks source link

Make changes to rely on ADL get instead of std::get in AFQMC #5239

Closed ye-luo closed 4 days ago

ye-luo commented 4 days ago

Proposed changes

Namely restore part of #5228 without update of multi.

What type(s) of changes does this code introduce?

Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

What systems has this change been tested on?

laptop

Checklist

Yes. This PR is up to date with current the current state of 'develop'

ye-luo commented 4 days ago

Test this please

correaa commented 4 days ago

This is the list of errors I see in the CI so far:

macos (macOS-GCC14-NoMPI-Real) 36 - deterministic-unit_test_estimators (Bus error) https://github.com/QMCPACK/qmcpack/actions/runs/11962263609/job/33350271019?pr=5239#step:7:2073

I see this one passing for what it is worth:

ornl-sulfur CI GCC11-MPI-MKL-AFQMC-Complex-Mixed

ye-luo commented 4 days ago

Test this please

ye-luo commented 4 days ago

@correaa AFQMC update seems good.

correaa commented 4 days ago

ok, so it is possible to merge then? I will keep working on the side to make the complex afqmc work with newer versions of Multi. But at least I can keep developing Multi without breaking the real version (and the rest of the code).

prckent commented 3 days ago

After this PR and those related to it on Thursday, the nightly tests are clear.