search

QMICodeBase / TORTOISEV4

Official TORTOISE Diffusion MRI Processing Pipeline V4 Source Code and Documentation
GNU General Public License v3.0
18 stars 4 forks source link

[ENH] extra logic for qsiprep building #3

Closed mattcieslak closed 1 year ago

mattcieslak commented 1 year ago

Hi @eurotomania, I'm working on changing the qsiprep build to clone directly from your repo instead of using a local copy of the code. Would you be OK with adding a QSIPREP option for cmake that can be used to enable/disable things to make the build easier?

Also - ITK 5.3 is out and it has your fix in it!

eurotomania commented 1 year ago

Hi Matt,

Of course. THough , can you remind me of this during the week again? I am pretty sure I will forget :)

On Sat, Feb 18, 2023 at 6:12 PM Matt Cieslak @.***> wrote:

Hi @eurotomania https://github.com/eurotomania, I'm working on changing the qsiprep build to clone directly from your repo instead of using a local copy of the code. Would you be OK with adding a QSIPREP option for cmake that can be used to enable/disable things to make the build easier?

Also - ITK 5.3 is out and it has your fix in it!

You can view, comment on, or merge this pull request online at:

https://github.com/eurotomania/TORTOISEV4/pull/3 Commit Summary

File Changes

(1 file https://github.com/eurotomania/TORTOISEV4/pull/3/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/eurotomania/TORTOISEV4/pull/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFQZWG3Y6KAHSNC7R2BWKDWYFJNVANCNFSM6AAAAAAVATLPNY . You are receiving this because you were mentioned.Message ID: @.***>

-- M. Okan Irfanoglu Graduate Student & GTA Computer Sciences & Engineering Ohio State University

mattcieslak commented 1 year ago

@eurotomania would you mind merging this PR? I'd like to add in your new features for T2 registration

eurotomania commented 1 year ago

Hi Matt,

As usual this completely slipped my mind. Will be done today.

On Thu, May 4, 2023 at 3:01 PM Matt Cieslak @.***> wrote:

@eurotomania https://github.com/eurotomania would you mind merging this PR? I'd like to add in your new features for T2 registration

— Reply to this email directly, view it on GitHub https://github.com/eurotomania/TORTOISEV4/pull/3#issuecomment-1535260121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFQZWCBFKRKL6G33QMJM63XEP4HPANCNFSM6AAAAAAVATLPNY . You are receiving this because you were mentioned.Message ID: @.***>

-- M. Okan Irfanoglu Graduate Student & GTA Computer Sciences & Engineering Ohio State University

mattcieslak commented 1 year ago

no worries! I fixed a merge conflict, so please take a look and if it's ready to go you should be able to just merge it