QMSS-G5063-2022 / group_f_f1

repo for f1 data viz final project
0 stars 0 forks source link

draft feedback #3

Open cchiao opened 2 years ago

cchiao commented 2 years ago

Final Thoughts:

ldeitz commented 2 years ago

@ds3478 do you have thoughts on the data table?

I can try to make the winners/points graphs in plot_ly! I was thinking about it earlier but wasn't sure what would be useful. It's probably helpful to at least have a hover for the driver name...the legends aren't that helpful.

I can add the incidents graphs for sure! And yes we are good to embed the video, it looks fairly simple based on what @ds3478 put together. Can you send me the link to the right one?

I'm not sure how to do side-by-side comparisons. Open to learning but I probably need to be pointed in the right direction...

cchiao commented 2 years ago

For the video links, I think this is the best one: https://www.youtube.com/watch?v=twAlqtvVMdc

but this one is also funny: https://www.youtube.com/watch?v=973X1xWClzc

ds3478 commented 2 years ago

For the Circuits map: 1) The "(All)" filter is misleading and not working as I originally intended (the fault is mine). I don't think it is broken, rather it is just filtering EVERYTHING lol. So we may not need the "(All)". Any objection for me to try to remove it?

[Donald: It turns out that the "(All)" option is due to the version of "crosstalk". If we use version 1.2, it brings in "(All)", if we use version 1.1, then there is no "(All)". The only other way I could think to remove it would be to use javascript, but it is not worth the effort in my opinion].

For the (Drivers) data table: 1) did we want to add the CSV export button? [Donald: this is done, CSV button is added] 2) any objections to remove the caption "Table 3: Drivers" [Donald: this is done, Lauren removed it] 3) any objections for us to add a "standings" or "ranking" column to the drivers table? if not, maybe we can leave the table sorted in ascending order by default on "standings" (i.e., the number 1 driver is first).

For the 2019 vs 2020, because they are separate I'm not sure how to read and interpret. We may have to put them next to each other, or use a visual with 2019 and 2020 as adjacent series.

Since everything is HTML, we can add HTML elements for for positioning and spacing between charts.

cchiao commented 2 years ago

@ds3478 I think adding a standings/ranking to the drivers table is a great idea. Maybe a points accumulation? Or any other indicator of how the driver did? The number of seasons they participated in? Or the number of wins/podiums?

cchiao commented 2 years ago

I went ahead and moved the driver's points in front of the standings bc standings explain points! @ldeitz

cchiao commented 2 years ago

I think the constructor's winning and points numbers are wrong in these graphs. There's no way that Mercedes can have 181 wins in a season (see 2019 graph). Is that you @nikkigsak ?

nikkigsak commented 2 years ago

Yeah thats me! Unsure why. Can someone help me look at the code and see if I wrangled it wrong?

ldeitz commented 2 years ago

Question about the Haas colors -- did they switch between 2019 and 2021? Just looking at the Incidents charts and the bars are different colors

Edit: tagging @cchiao right?

cchiao commented 2 years ago

hi! yes i think they did switch colors, but happy to just pick one for continuity

ldeitz commented 2 years ago

I tried to embed the video but the HTML keeps saying that it has to be watched on YouTube :/

cchiao commented 2 years ago

some collected thoughts for whoever gets to them first (@ds3478 or @nikkigsak?)! This is mostly a list for me, but thought it would be helpful to write down/document somewhere:

thanks!