search

QMSTR / qmstr

QMSTR compliance tool
https://qmstr.org
31 stars 1 forks source link

Remove docker dependecies in application code #457

Open zetoph opened 4 years ago

zetoph commented 4 years ago

Some QMSTR functionality is currently implemented in the go application code using the golang docker library. In order to enable flexible deployments and configuration, these dependencies should be eliminated from the application and shifted to known tools (such as helm, docker cli, docker-compose, kubectl)

zetoph commented 4 years ago 
% grep -R "github.com/QMSTR/qmstr/lib/go-qmstr/docker" ./       
./lib/go-qmstr/cli/copy.go: "github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/log.go:  "github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/snapshot.go: "github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/spawn.go:    "github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/start.go:    "github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/quit.go: "github.com/QMSTR/qmstr/lib/go-qmstr/docker"
Binary file ./out/qmstrctl matches
../lib/go-qmstr/cli/copy.go:    "github.com/docker/docker/client"
../lib/go-qmstr/cli/log.go: "github.com/docker/docker/client"
../lib/go-qmstr/cli/clean.go:   "github.com/docker/docker/client"
../lib/go-qmstr/cli/snapshot.go:    "github.com/docker/docker/client"
../lib/go-qmstr/cli/spawn.go:   "github.com/docker/docker/client"
../lib/go-qmstr/cli/start.go:   "github.com/docker/docker/client"
../lib/go-qmstr/cli/quit.go:    "github.com/docker/docker/client"
../lib/go-qmstr/docker/copy.go: "github.com/docker/docker/client"
../lib/go-qmstr/docker/master.go:   "github.com/docker/docker/client"
../lib/go-qmstr/docker/client.go:   "github.com/docker/docker/client"
fullsushidev commented 4 years ago

I think this is already done, right @marcomicera ?

marcomicera commented 4 years ago

Such a grep still shows some occurrences of that module. I'll look into this.