Closed rplociennik closed 6 years ago
Well, apparently there was a problem with 3rd party PPA with Qt 5.9 while performing one of Travis' builds...
Can you please update installing right version of the PPA in travis build script? I guess replacing ppa:beineri/opt-qt59-trusty
with ppa:beineri/opt-qt593-trusty
should make it pass.
Right, there we go.
Alright, I hope I haven't overdone it this time.
The changes have been split into smaller commits and described to better reflect the idea behind them.
I've decided to preserve the old remove_lines
and simply make sure that the setting gets properly saved and loaded which was pretty much the main intention all along.
Secondly, since the meaning of remove_lines
and remove_words
residing in a single config file seems unclear, I'm proposing changing the latter to remove_lines_words
.
All renames are followed up by refactors across other classes in order to maintain consistency.
I think your initial naming proposal was quite good. Anyway - the most important is to have backwards compatibility kept and decent naming consistency.
I'm happy to merge this PR. Thank you for valuable piece of work 👏
Thank you for accepting these changes and for the kind words.
I only hope I could have described them more precisely to begin with. ;)
Additionally, rename associated 'cbRemoveLines' to 'cbRemoveWords' in frmOptions to match the PostProcessingConfig setting.