search

QNetITQ / WaveFox

Firefox CSS Theme/Style for manual customization
MIT License
1.02k stars 48 forks source link

Adding a certain line in userChrome removes the background highlight from the tab you're currently on. #168

Closed onthejobtraining closed 10 months ago

onthejobtraining commented 10 months ago

Sorry if this is not related to wavefox itself, but I don't know where else to ask about it.

I am currently using the latest wavefox in firefox 119 with the only change in the userChrome.css being the addition of this line: .titlebar-close {display:none !important;}

Upon adding this line to your userChrome.css, you will notice that firefox will no longer highlight the tab you're in

This is Firefox with the above line and as you can see, I'm on the settings page but it's not highlighted. image

Now this is on the same profile without that particular line: image

Could this be fixed somehow?

QNetITQ commented 10 months ago

The background of the active tab and the property you are trying to add are not related in any way. Add your property to the very bottom of the windows.css file, behind all the brackets. You have a Windows, right?

onthejobtraining commented 10 months ago

Add your property to the very bottom of the windows.css file, behind all the brackets.

Wow, huge thanks, that worked perfectly. So basically I shouldn't touch userChrome.css but instead try things on the windows.css file from now on. Thank you again.

Edit: I've noticed one difference between putting the line in userchrome.css and windows.css: When you put the line in userChrome.css the minimize and maximize icons are full sized: image

But when I put it in windows.css the buttons got smaller and not fully extending to the bottom: image

QNetITQ commented 10 months ago

Not certainly in that way. userChrome.css contains properties and functions common to all systems. windows.css, mac.css and linux.css contain properties specific to each system. Users should not go there at all. But your report gave me one idea. From version 120 I will make a separate file that will overwrite any sections of the style. This way you don’t have to go into styles at all, just add a file with your properties to the folder and that’s it.

onthejobtraining commented 10 months ago

Btw did you make any changes to the List all tabs button in the recent wavefox update? Previously it was round shape (like the present open a new tab button) but now list it has the default firefox look (rectangular with curved edges)

QNetITQ commented 10 months ago

Yes. I removed the curves from some elements. Temporary or not, I don’t know yet.

onthejobtraining commented 10 months ago

Thanks, love your work 🔥