QOAL / localisetime

A web extension for localising times found in web pages
GNU General Public License v3.0
14 stars 0 forks source link

Recognize typed out time zone names #11

Closed Ijee closed 3 years ago

Ijee commented 3 years ago

Hey,

I just noticed that the extension does not detect / convert the given time if it is written in this manner:

November 4th at 6:00 AM Pacific Time

This is the second time I encountered it and this example can be found here.

Sadly I don't have time to further investigate why it does not get recognized which is why I am kind of guessing here - sorry for being ambiguous.

Great work so far!

QOAL commented 3 years ago

Hi, Thanks for opening this issue.

The extension only detects timezone abbreviations currently, but there's clearly value in detecting full names too.

I think I can support this with a bit of regex and by including more data, so I'll have a play around.

Ijee commented 3 years ago

Seems like the extension does the functionality now.

Thanks for the swift implementation!

QOAL commented 3 years ago

Ah cool, I'm glad to hear it's working as expected.