Login failure to ecoinvent, also seems to have problems with ReCiPe endpoint indicators (midpoint seems fine)

QSD-Group / BW2QSD

An interface between Brightway2 and the QSD packages for life cycle assessment data importing

Other

2 stars 0 forks source link

Login failure to ecoinvent, also seems to have problems with ReCiPe endpoint indicators (midpoint seems fine) #3

Closed yalinli2 closed 6 months ago

yalinli2 commented 6 months ago

A reminder to look into these issues, probably time to update to work with brightway25

yalinli2 commented 6 months ago

After updating the eidl module following https://github.com/haasad/EcoInventDownLoader/tree/master, login part has been fixed, but new bugs appear when extracting the data.

In the future it might be best to go back using eidl instead of embedding it in BW2QSD, and it might be better to migrate the relevant modules to QSDsan.

yalinli2 commented 6 months ago

This bug related to impact indicators (qsdsan.ImpactIndicator.load_from_file) has been fixed: https://github.com/QSD-Group/QSDsan/commit/7f0b8132c737bec251f2b00009f081f8d79cc63e

Though the bug was not because of BW2QSD, the incompatibility with the new ecoinvent interface still causes problem, the best solution is probably to still use EcoInventDownloader (though it doesn't have a PyPI package, but it's on GitHub: https://github.com/haasad/EcoInventDownLoader), other functions in BW2QSD can be migrated to QSDsan.

yalinli2 commented 6 months ago

Closing this issue since the bug has been fixed, but opened #4 until I figure out a good way to maintain the functionalities.