search

QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems
https://qsdsan.com
Other
16 stars 6 forks source link

Resin density #15

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

Why is this commented out? https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/_cmps.py#L152

yalinli2 commented 2 years ago

@lsrowles just to tag you, I probably should've done this when I opened the issue, thanks!

lsrowles commented 2 years ago

@yalinli2 I think I was not sure if this should be dry or wet density when it was added. Would dry be best since water could be another cmp in the stream if necessary? If so, I think 750 kg/m3 is appropriate for the resin. Thanks!

yalinli2 commented 2 years ago

@lsrowles either wet or dry is fine, it just depends on how you want to model the resin (e.g., you can model biodiesel as a mixture of components or just as a general one representing all of them), let's just go with dry. But I didn't see water added anywhere?

Additionally, can you take a look at the comments here and let me know if we still need them? Thanks! https://github.com/QSD-Group/QSDsan/blob/gates/qsdsan/sanunits/_ion_exchanges.py

yalinli2 commented 2 years ago

A note that 750 kg/m3 is used as the density for resin now