search

QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems
https://qsdsan.com
Other
16 stars 6 forks source link

Consolidate functions #21

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

Right now all the systems in the gates are set up in a similar way, but util functions like batch_setting_unit_params are defined in those systems, some of them have been updated with time, but some not, leading to some bugs. These functions should be consolidated to a central place

yalinli2 commented 2 years ago

A note to look through all the models.py, since some scripts, though not defined as functions, have the similar structure (e.g., here)

yalinli2 commented 2 years ago

Also, rewrite systems.py and recreate systems every time a new model is created

yalinli2 commented 2 years ago

See #17, work ongoing now, will open an issue in the exposan-private repo about this