search

QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems
https://qsdsan.com
Other
16 stars 6 forks source link

Bug in N recovery calculation #3

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

I think the codes here (and all other places that use a similar way to calculate N recovery): https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/systems.py#L526

should be

sysA_N_toilet_fugitive_out = A2.outs[3].imass['N2O'] * (28/44) * time_period

One mol of N2O has two N atoms

yalinli2 commented 2 years ago

yes should be 28 instead of 14

yalinli2 commented 2 years ago

This has been fixed in the new BR system in the gates branch