search

QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems
https://qsdsan.com
Other
16 stars 6 forks source link

Move units to QSDsan #30

Closed yalinli2 closed 1 year ago

yalinli2 commented 1 year ago

Hi @jiananf2 , I separated the units that I think would be useful to other systems in the units_to_move dir, can you copy all the scripts there to the sanunits dir in QSDsan (in the pfas branch)? For scripts with the same name (like _abstract.py), you can just copy the codes into the original scripts.

I want you to do this so that the commits would be counted as your contribution. After you copy those scripts in, I'll clean them up on both QSDsan and EXPOsan and make sure the results are unchanged, thanks!

jiananf2 commented 1 year ago

Done!

yalinli2 commented 1 year ago

ah I didn't notice I opened the PR to main instead of pfas, I'll clean up the htl module and add test today