Open a draft PR for discussion. Just added the layout and made sure the system can be created (using the most basic configuration in the report (and praying they have this implementation in MATLAB)
Note: you need to use the metro branch of QSDsan, although the unit operations need some cleanup
Didn't dare to let it simulate at all, haven't looked at the parameter settings, etc. But first need to figure out:
Can I pretty much just copy the entire bsm1 layout into bsm2?
There's a storage tank in the config that we don't have, using HydraulicDelay for now.
Also not about BSM2 but BSM1 - does it make sense to run BSM1 using ASM2d? I made some changes in the bsm1 module to allow this, but it might make no sense at all.
And on DiffusedAeration, would be nice to store DO_ID so that when creating aerobic tanks, we can just get the DO_ID from the process.
yalinli2
commented
8 months ago
Open a draft PR for discussion. Just added the layout and made sure the system can be created (using the most basic configuration in the report (and praying they have this implementation in MATLAB)
Note: you need to use the
metrobranch ofQSDsan, although the unit operations need some cleanupDidn't dare to let it simulate at all, haven't looked at the parameter settings, etc. But first need to figure out:
HydraulicDelayfor now.Also not about BSM2 but BSM1 - does it make sense to run BSM1 using ASM2d? I made some changes in the
bsm1module to allow this, but it might make no sense at all.And on
DiffusedAeration, would be nice to storeDO_IDso that when creating aerobic tanks, we can just get theDO_IDfrom the process.