QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems

https://qsdsan.com

Other

16 stars 6 forks source link

Questions for BSM2 module #44

Open yalinli2 opened 7 months ago

yalinli2 commented 7 months ago

Documenting questions related to implementing the BSM2 configuration in EXPOsan: https://github.com/QSD-Group/EXPOsan/tree/bsm2/exposan/bsm2

Tables, etc. below refer to the BSM2 report if not otherwise noted: http://iwa-mia.org/wp-content/uploads/2022/09/TR3_BSM_TG_Tech_Report_no_3_BSM2_General_Description.pdf

yalinli2 commented 7 months ago

ADM/Anaerobic Digester

[ ] Need to figure out where all the parameters in Tables 5-8 are set for adm1/AnaerobicCSTR

yalinli2 commented 7 months ago

Primary Clarifier

[ ] Need to figure out where f_X and f_XS are set
[ ] Not sure why HRT is set, rather than V

yalinli2 commented 2 months ago

@joyxyz1994

Currently the ASM2ADM and ADM2ASM junctions work about right, still minor differences in some components but largely match the results.

After providing some initial conditions the system can miraculously run, but the results are awfully wrong...

joyxyz1994 commented 2 months ago

Would you be able to join the office hour today? If no one shows up, we can work on this together.

@joyxyz1994

Currently the ASM2ADM and ADM2ASM junctions work about right, still minor differences in some components but largely match the results.

After providing some initial conditions the system can miraculously run, but the results are awfully wrong...

yalinli2 commented 2 months ago

yep that's my plan, thanks & talk to you later!

Would you be able to join the office hour today? If no one shows up, we can work on this together.

yalinli2 commented 2 months ago

@joyxyz1994 I tried to run the test for the bsm2 module but it didn't pass... which branches of QSDsan/EXPOsan should I be using?

If you've gotten the results close enough to the matlab model, can you send in a PR to merge into main? Thanks!

joyxyz1994 commented 2 months ago

I used qsdsan@metro-bsm2 and exposan@bsm2. The maximum relative error I got was around 0.018. I didn't merge because I haven't checked the other sludge treatment units that Saumitra developed yet. Would you prefer we merge anyway?

yalinli2 commented 2 months ago

Ah if that's the case let's wait till that's figured out - I just realized that we need to merge in the updates in @.***

I'll rerun the tests locally, I thought I was using the exact same branches as you and I pulled in the recent changes....

From: Xinyi Joy Zhang @.> Sent: Tuesday, April 30, 2024 6:00 PM To: QSD-Group/EXPOsan @.> Cc: Yalin @.>; Author @.> Subject: Re: [QSD-Group/EXPOsan] Questions for BSM2 module (Issue #44)

I used @. and @. The maximum relative error I got was around 0.018. I didn't merge because I haven't checked the other sludge treatment units that Saumitra developed yet. Would you prefer we merge anyway?

— Reply to this email directly, view it on GitHubhttps://github.com/QSD-Group/EXPOsan/issues/44#issuecomment-2087498224, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALV5VLL2JHXDGIFXOODT2DTZAAH6RAVCNFSM6AAAAAA7IE6GOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGQ4TQMRSGQ. You are receiving this because you authored the thread.