search

QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems
https://qsdsan.com
Other
16 stars 6 forks source link

Power calculation #5

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

If 20 is the lifetime of the system, what is 12? Why is it not 24 (hr per day)? https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/systems.py#L689

Additionally, this way of calculation won't give the correct answer if there's uncertainty around lifetime

yalinli2 commented 2 years ago

12 is because it's assuming running 12 hours/day

yalinli2 commented 2 years ago

@lsrowles I left comments in the updated system in gates on this, additionally, I noticed the original codes didn't include this 3651220 for sysC and sysD, I assume these systems weren't really used in the manuscript?

yalinli2 commented 2 years ago

This has been updated - currently in the exposan-private repo (some systems are NDA-protected) but will soon be reflected here