search

QSD-Group / EXPOsan

EXPOsition of sanitation and resource recovery systems
https://qsdsan.com
Other
16 stars 6 forks source link

Recovery calculation #6

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

Why right-hand side of line 942 and 944 are the same? https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/systems.py#L942 https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/systems.py#L944

yalinli2 commented 2 years ago

carbon_dict['treat_liq']['sysB'] might not be used anywhere, remove it

yalinli2 commented 2 years ago

@lsrowles actually, these functions are called when recording model metrics, e.g.,: https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/models.py#L116 https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/models.py#L138 https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/models.py#L162 https://github.com/QSD-Group/EXPOsan/blob/8420ffcf100b34ab6c98ba9922986863b69b6b2f/exposan/biogenic_refinery/models.py#L185

Should we just remove them?

yalinli2 commented 2 years ago

All recovery calculation functions have been updated, still not sure what the treat_liq stands for, but they are not used anywhere and have been removed