QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 14 forks source link

Ecc edits #101

Closed smitimittal closed 1 year ago

smitimittal commented 1 year ago

Updating the ecc module to reflect values and defaults from the Tarpeh Lab's experiments, and updating the doctest to be functional

codecov[bot] commented 1 year ago

Codecov Report

Merging #101 (d57db15) into main (2e8947e) will decrease coverage by 0.07%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   74.71%   74.64%   -0.07%     
==========================================
  Files          93       93              
  Lines       16038    16043       +5     
  Branches     1701     1701              
==========================================
- Hits        11983    11976       -7     
- Misses       3583     3593      +10     
- Partials      472      474       +2     
Flag Coverage Δ
unittests 74.64% <100.00%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
qsdsan/sanunits/__init__.py 100.00% <ø> (ø)
qsdsan/equipments/_electrode.py 93.61% <100.00%> (ø)
qsdsan/sanunits/_electrochemical_cell.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

yalinli2 commented 1 year ago

Fixed some minor issues, mostly related to the minor number changes brought by newer BioSTEAM/Thermosteam. Thanks @smitimittal and @akogler for the contributions!