Open yalinli2 opened 1 year ago
@RaiSaumitra I took a quick look and added notes (I think you've started reviewing them so that's great). When @joyxyz1994 is back we should ask her to review before merging into the main
branch.
The tests actually passed but something happened with Codecov (this is to check how much code is covered by the tests), not exactly sure why but maybe it's because it's a draft PR not an actual PR? I'll figure this out later.
Thanks!
Attention: Patch coverage is 29.18149%
with 2189 lines
in your changes missing coverage. Please review.
Project coverage is 66.97%. Comparing base (
b973f6c
) to head (0800ffd
). Report is 14 commits behind head on main.:exclamation: Current head 0800ffd differs from pull request most recent head 3db40fe
Please upload reports for the commit 3db40fe to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@RaiSaumitra I resolved conflicts between metro
and main
, fixed some minor bugs in metro
, and merged in main
(see cb8a746)
I'll do this periodically in the future as I work on the BSM2 config, let me know if I messed anything on your system, thanks!
ps, the tests are failing due to some other issues and I'm trying to get those fixed
btw on the degradability and organic property of components, we should be consistent with the default (qsdsan/data/_components.tsv):
but @RaiSaumitra I think you set things differently (metroASM2d.py)
also, you don't have to use Component.from_chemical
if you provide search_ID
, i.e., you can just
CO2 = qs.Component('S_CO2', search_ID='CO2', particle_size='Dissolved gas', degradability='Undegradable', organic=False)
@RaiSaumitra I'm making this a draft PR so we can discuss any needed updates, some of my changes could be style-related for easier understanding/improve in speed