search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
29 stars 11 forks source link

Update QSDsan capacity pages #106

Closed yalinli2 closed 11 months ago

yalinli2 commented 11 months ago

Open an issue here so I don't forget! Refer to the internal email for details, but the idea is to have a page that shows what is currently in QSDsan. In the past we have a page for the developed processes, unit operations, and systems, but I haven't updated it for quite some time.

Additionally, since we are developing the benchmarking configurations, it'll be great if we can have one page dedicated to it (or add to existing pages).

joyxyz1994 commented 11 months ago

I'm leaning toward adding the benchmark configurations into the "systems" page. Many of the unit operations and process models are already included in the developed "processes" and "unit operations".

yalinli2 commented 11 months ago

sounds good, could have one section that list the 25 configurations (and I gonna steal the nice figure you made) 😉

I'll make this my homework before next week's coordination call

yalinli2 commented 11 months ago

note that I also want to add the link to the AWESOME tutorial slides @GaYeongKim is developing and update the developer page to acknowledge the new contributors

joyxyz1994 commented 11 months ago

No problem. Let me send you the original file of that figure.

yalinli2 commented 11 months ago

hmmmmm I updated the pages but somehow one test failed: https://github.com/QSD-Group/QSDsan/actions/runs/6375099195

It's not related to what I changed, and my local tests (even after I updated my local matplotlib) all pass, no clue why this is happening, @joyxyz1994 can you pull beta and see if tests pass on your end? Thanks!

yalinli2 commented 11 months ago

Done in #107!