search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
29 stars 11 forks source link

Add in ADM1 tutorial #110

Closed yalinli2 closed 10 months ago

yalinli2 commented 10 months ago

Many thanks to @GaYeongKim who prepared a tutorial doc on ADM1 model. I'm opening an issue here to remind myself to merge it in

yalinli2 commented 10 months ago

just added this in! https://qsdsan.readthedocs.io/en/beta/tutorials/12_Anaerobic_Digestion_Model_No_1.html

note that you won't be able to see it in the main page of QSDsan's docs because the changes are still on the beta branch because some weird bugs are making QSDsan's tests fail (unrelated to your tutorial), I'll merge these changes in main after I fix the bug, thanks for the contribution!!!

yalinli2 commented 10 months ago

I'm keeping this issue open until I fix the bug and merge main in

also the intra-page hyperlink for the different section titles aren't working now... would want to see if there can be fixes, but it doesn't matter that much because the doc theme has a navigation bar on the right

yalinli2 commented 10 months ago

well, now that the test is shown as failed due to the merge in dev, I'll just push these changes to main then, I did bump on the versions on both QSDsan and EXPOsan in hope to fix the problem... but we'll see

yalinli2 commented 10 months ago

following up the test error in #111, fixed & explanation in #112