search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 14 forks source link

Fixing test due to typos in setup.py #112

Closed yalinli2 closed 1 year ago

yalinli2 commented 1 year ago

Thought it might benefit someone (probably me) in the future, I banged my head against the wall for several days wondering why the tests keep failing due to ModuleNotFound error on EXPOsan's reclaimer module, while all tests on EXPOsan (that include more robust tests on reclaimer are totally fine), turns out I MISSED A COMMA after 'pou_disinfection/data/*' when I was updating it to include the disinfection module image

I should've checked it more closely when I was suspecting that I messed up the config file... And I should've realized that something else was wrong when I removed the test related to reclaimer but the workflow again failed due to ModuleNotFound on metab.utils (I forgot /* after metab/data' and metab/utils'

The next time I should build the PyPI packages locally to double-check all the folders are there...

yalinli2 commented 1 year ago

Clearly I still wasn't looking at it CLOSELY enough, should've also added pou_disinfection/*', orz

Closing this after fix it in https://github.com/QSD-Group/EXPOsan/commit/d658a3c85d65ce49868264dc82b9faa8c9d42ece and all tests passed (FINALLY)