QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

Dev #122

Closed joyxyz1994 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@e220748). Click here to learn what that means.

Files Patch % Lines
qsdsan/_process.py 27.27% 8 Missing :warning:
qsdsan/sanunits/_anaerobic_reactor.py 50.00% 3 Missing and 1 partial :warning:
qsdsan/sanunits/_suspended_growth_bioreactor.py 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #122 +/- ## ======================================= Coverage ? 74.18% ======================================= Files ? 91 Lines ? 16053 Branches ? 1693 ======================================= Hits ? 11909 Misses ? 3688 Partials ? 456 ``` | [Flag](https://app.codecov.io/gh/QSD-Group/QSDsan/pull/122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=QSD-Group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/QSD-Group/QSDsan/pull/122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=QSD-Group) | `74.18% <53.33%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=QSD-Group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yalinli2 commented 4 months ago

I'll merge this in, I'm having issues with Codecov recently despite multiple tries to fix it... But since all the tests are passed here maybe it somehow has been fixed?

yalinli2 commented 4 months ago

Oh perfect Codecov fixed itself/you fixed Codecov 🎉 @joyxyz1994

joyxyz1994 commented 4 months ago

haha cool! I'm not sure what happened lol..