Closed joyxyz1994 closed 1 month ago
Awesome! I hope I can take a look this weekend and merge them in, will aim to release new packages of QSDsan/EXPOsan as well, thanks!
From: Xinyi Joy Zhang @.> Sent: Tuesday, October 15, 2024 4:59 PM To: QSD-Group/QSDsan @.> Cc: Yalin @.>; Review requested @.> Subject: [QSD-Group/QSDsan] New process models and units for WRRF plant-wide simulations (PR #124)
Compatible with @.***
You can view, comment on, or merge this pull request online at:
https://github.com/QSD-Group/QSDsan/pull/124
Commit Summary
get_SRT
util func to deal with no biomass wastemetro-bsm2
& resolve bugIdealClarifier
PrimaryClarifier
ADM1_p_extension
ASM2dtomADM1
mADM1toASM2d
IdealClarifier
and update doctestPFR
PFR
, AnaerobicCSTR
PFR
mASM2d
ADM1p
mASM2d
-ADM1p
interface modelsmASM2d
and ADM1p
PFR
maximum_nonsettleable_solids
in Takacs clarifierAnaerobicCSTR
mASM2d
AnaerobicCSTR
pH controlADM1p
PrimaryClarifier._design()
PrimaryClarifier._design_pump()
PrimarycClarifier._cost()
File Changes
(30 fileshttps://github.com/QSD-Group/QSDsan/pull/124/files)
Patch Links:
— Reply to this email directly, view it on GitHubhttps://github.com/QSD-Group/QSDsan/pull/124, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALV5VLJCZXKNNXKKSSEYFMTZ3V62RAVCNFSM6AAAAABQAAERBKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DSOJRGIYTGMI. You are receiving this because your review was requested.Message ID: @.***>
I'm merging this in since local tests passed, there was some installation issue since I updated setup too soon...
Compatible with EXPOsan@bsm2