search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 14 forks source link

More flexible hydrothermal units #125

Open yalinli2 opened 13 hours ago

yalinli2 commented 13 hours ago

@jiananf2 FYI, I'm hoping to update the hydrothermal units so that they are more flexible (i.e., not written in the context of sludge/WWTP, not necessarily using the predictive models, etc.). In the future, I probably will move your hydrothermal/hydroprocessing units to the htl module in EXPOsan and put the new units (still largely based on your codes) in QSDsan.

I'm using this issue to document the changes.

yalinli2 commented 13 hours ago

In Hydrocracking, the two hxs are defined as heat_exchanger_H2 and heat_exchanger_oil, is the name correct in defining the auxiliary units? I tried to change the names but it'll trigger the error, so I'm suspecting that those hxs were not included in the simulation. Also not sure if their costs were included. https://github.com/QSD-Group/QSDsan/blob/9afc0339ce19643020a52a51a8fb62a14910f683/qsdsan/sanunits/_hydroprocessing.py#L78

yalinli2 commented 10 hours ago

@jiananf2 why are the products from Hydrocracking/Hydrotreating in gas phase?

https://github.com/QSD-Group/QSDsan/blob/9afc0339ce19643020a52a51a8fb62a14910f683/qsdsan/sanunits/_hydroprocessing.py#L167

https://github.com/QSD-Group/QSDsan/blob/9afc0339ce19643020a52a51a8fb62a14910f683/qsdsan/sanunits/_hydroprocessing.py#L421