search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

`WasteStream` models need updating #40

Closed yalinli2 closed 3 years ago

yalinli2 commented 3 years ago

Hey @joyxyz1994, I got some errors while making the tutorial, I think IDs of some of the Component have been updated, but not yet reflected in the models (e.g., SU_Inf below should probably be S_U_Inf).

https://github.com/QSD-Group/QSDsan/blob/dc5b7b7202bb514afa13815ed01a056873436450/qsdsan/_waste_stream.py#L1253

Can you take a look and update as needed? Thanks!

joyxyz1994 commented 3 years ago

Hi @yalinli2, it should be fixed now. Let me know if you run into any other problem! Thanks!

yalinli2 commented 3 years ago

Yep I think it's fixed, thanks Joy!