search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 14 forks source link

fix bugs and add docs for `Process` #50

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

@joyxyz1994 Take a look and merge if you don't see problems? Feel free to update - you are much more familiar with this class than me 😊 Thanks!

joyxyz1994 commented 2 years ago

@yalinli2 this looks good! I'll go ahead and merge. Thanks!!

yalinli2 commented 2 years ago

Ah definitely no!

On Sun, Feb 6, 2022 at 10:59 AM Joy Zhang @.***> wrote:

@.**** commented on this pull request.

In qsdsan/utils/parsing.py https://github.com/QSD-Group/QSDsan/pull/50#discussion_r800206512:

@@ -156,7 +156,8 @@ def get_stoichiometric_coeff(reaction, ref_component, components, conserved_for, coeff_dct = symbolize(coeff_dct, components, conserved_for, parameters) coeff = dct2list(coeff_dct, components) if ref_component:

  • normalize_factor = abs(coeff[components._index[ref_component]])
  • try: normalize_factor = abs(coeff[components.index(str(ref_component))])

Do we still need the breakpoint here?

— Reply to this email directly, view it on GitHub https://github.com/QSD-Group/QSDsan/pull/50#pullrequestreview-874062100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALV5VLNSTLGTIYUU5NCXBOTUZ2SFVANCNFSM5NUG5OZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>