search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

Check consistency of `price_ratio` usage #54

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

The price_ratio attribute should be used for

Anything related to the parts/materials of the system, but no labor

Not sure if this has been used consistently, need to double-check

yalinli2 commented 2 years ago

Additionally, I've added a price_ratio decorator to the utils module, for example usage, see here: https://github.com/QSD-Group/QSDsan/blob/op/qsdsan/sanunits/_control_boxes.py

yalinli2 commented 2 years ago

@lsrowles I think this hasn't been done for BR units, can you update the spreadsheet here: https://docs.google.com/spreadsheets/d/1-NWmtSeR8i_m85gjo55Fiq_SsPD0Fk2j2zaSSOLR1b0/edit#gid=0

Column F, "Price Level Ratio Applicable"

yalinli2 commented 2 years ago

@lsrowles I think this hasn't been done for BR units, can you update the spreadsheet here: docs.google.com/spreadsheets/d/1-NWmtSeR8i_m85gjo55Fiq_SsPD0Fk2j2zaSSOLR1b0/edit#gid=0

Column F, "Price Level Ratio Applicable"

Done now