QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

Consolidating similar units across systems #56

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

There are several similar units in different systems (e.g., IndustrialControlPanel, SystemControls), I'd like to consolidate them into fewer modules with some renaming for consistency and better organization, specifically

The following units will go into qsdsan/sanunits/_ion_exchange.py (see #55):

The following units will go into qsdsan/sanunits/_controlling.py:

The following units will go into qsdsan/sanunits/_hxs.py:

yalinli2 commented 2 years ago

Other changes:

yalinli2 commented 2 years ago

Copying the notes on the differences between the various IX units from #65:

NEWgen & Reclaimer use zeolite (adsorbent, resin, a general term), have diff weights & regeneration freq.,

NEWgen & Reclaimer also have GAC, process is the same, just cost/materials

The type of acids can be different as well

See if it's better for 1 unit or different ones

yalinli2 commented 2 years ago

As the many of the units (especially data) are specific to each system despite the similarity in their names, I think it'd better to consolidate the units for one system into one module, will do this when merging the gates branch into main