Clean up legacy comments

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.

https://qsdsan.com

Other

30 stars 12 forks source link

Clean up legacy comments #57

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

Need to to addressed or removed if it's outdated, listed by units in following posts

General ones:

breakpoints if you've done debugging, they shouldn't be there

yalinli2 commented 2 years ago

ScrewPress:

yalinli2 commented 2 years ago

CabonizerBase & PollutionControlDevice :

These emissions aren't there: https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_carbonizer_base.py#L64
Adding cost this would prevent the price of stainless steel, etc. from being updated to the same price across system (should've set the price of the corresponding impact items) https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_carbonizer_base.py#L209
Looks like the unit tries to calculate energy and N balance, but it doesn't actually add any checks
Is this already added or not? https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_carbonizer_base.py#L263

yalinli2 commented 2 years ago

PollutionControlDevice (in addition to above):

It should be in kg/hr, not g/hr https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_pollution_control_device.py#L106

yalinli2 commented 2 years ago

DryerFromHHX

yalinli2 commented 2 years ago

IonExchangeNH3 https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_ion_exchange_NH3.py#L97 https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_ion_exchange_NH3.py#L105 https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_ion_exchange_NH3.py#L110 https://github.com/QSD-Group/QSDsan/blob/e9fdbf1e6ed25685ce31093f5a58eced6c5eabc7/qsdsan/sanunits/_ion_exchange_NH3.py#L173

haclohman commented 2 years ago

Finished for SCG Aquonic.

yalinli2 commented 2 years ago

Cool, thanks @haclohman , can you pull changes from main so that your branch isn't behind? I'll try to take a look this week, thanks!

haclohman commented 2 years ago

Done!

yalinli2 commented 2 years ago

After @lsrowles posted the differences between his local codes and the GitHub version, I'll do a sweep for BR's units and remove the legacy comments (I've done this for the biogenic_module in EXPOsan )

yalinli2 commented 2 years ago

I think this is largely done, I'll give the codes another look when merging them into the main branch